Postgres Pro
Downloads
Home   >   mailing lists

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure
Date
Msg-id CAFOhELf4f4S137RmtGf-zHz0K2FOc9z+DHJsVHQMkDtPtRM=0g@mail.gmail.com
Whole thread Raw
In response to Feature #7178 - PostgreSQL deployment on Microsoft Azure  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
Responses Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Yogesh,

Review comments:
  • Step 2: The below statements should be in a different line, like
    • "Azure CLI" will use the currently logged in identity through Azure CLI on the local machine.
    • "Interactive Browser" opens a browser to authenticate a user interactively.
  • Disable the next button once authentication is complete.
  • Cluster name availability call calls the server on every field change
  • Availability zone needs description
  • Add High availability option


Code:
  • check_cluster_name_availability should be using the GET method instead of Post
  • Fix SonarLint issues
  • Do we need the cache_persistence_options as it will create the persistent storage which we do not require I guess?
  • Why do we need to call _get_azure_credentials on every request? Can't we store it in the session object?
  • Use gettext wherever required in the js file

Thanks,
Khushboo

On Wed, 1 Jun 2022, 10:11 Yogesh Mahajan, <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find the attached patch which provides functionality to deploy a Postgres cloud instance on Azure Postgresql.

Thanks,
Yogesh Mahajan
EnterpriseDB

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: [Patch] - Housekeeping #7315 - Update pgAdmin4 doc for Traefikv2 containerization
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin][RM7351]: Templates not displayed