Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing thecolumns in the existing view - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing thecolumns in the existing view
Date
Msg-id CAFOhELeDDEVtAFNE1FjiUEtu7TqFzUFxwi4DysfqvT8AsS6TDg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing thecolumns in the existing view  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing thecolumns in the existing view
List pgadmin-hackers
Hi Akshay,

On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

Following are the review comments:
  • Fix the PEP8 issue.
  • Drop query should be part of the jinja template for consistency. Currently, it is added through the python file.
The Delete query is already in the template file, I have just reused the delete call and merged the SQL queries in the python file. 
  • Any changes in the view code should not warn the user "Changing the columns in a view requires dropping...." and we should not drop the view. For example, I have only change the WHERE clause or added 'ORDER BY'. 
I have tested but  couldn't reproduce this issue.  Can you please let me know the proper use case?

Thanks,
Khushboo
 

On Tue, Jan 14, 2020 at 10:27 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for RM #5053 - Getting an error while changing the columns in the existing view.

PostgreSQL doesn't allow to change the view columns. So, while performing this task the existing view should be dropped first and then recreate it and also user will get a warning first.

Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: pgAdmin 4 - gettext usage fixes
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing thecolumns in the existing view