Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false
Date
Msg-id CAFOhELcsgAEFpi6CPqVRcqUAkWUpYi5AP=QCNUm2Ndp4kBV+bg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

Please find the attached updated patch.

On Fri, Nov 18, 2016 at 7:45 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, Nov 18, 2016 at 1:03 PM, Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch for RM #1801: Properly handle databases with
> datallowconn == false.
>
> Issue: While connecting the database, allowconn parameter was not in
> consideration.  Also, the database properties query call was on the selected
> database which was not correct.
>
> Fix: Put the check of  allowconn, while connecting the database in JS file.
> Also, the database properties query call set to the maintenance database.

All good, but this is just infrastructure for what's really required;
i.e. disabling menu options to do things like backups, run the query
tool etc. (anything that needs a connection). Can you resolve that
please?

 
Fixed
 
Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Ignore generated resource files
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Use QT 5.7 by default on Windows.