> - I polished the patch to reserve replication slots for REPACK. Given > the new implementation of 0006 that was submitted implies that we can > now run multiple repacks concurrently, I changed the default of 1 to 5.
Srinath let me know that this new part was causing CI failures on Windows. This version v51 should be okay (or, at least, it passes for me on CI).
yes indeed , TotalMaxReplicationSlots was the culprit , as the window after getting repack worked was forked , i think this was set back to 0. Thanks for fixing this with "repack" flag , initially i thought why can't we go with a macro #define TotalMaxReplicationSlots (max_replication_slots + max_repack_replication_slots) but i thought maybe in future we might need this "repack" flag to add more slot requirements.
