On Thu, 11 Jun 2026 at 16:31, Maksim.Melnikov <m.melnikov@postgrespro.ru> wrote:
>
> Patch with fixes was attached. Thanks for review.
You removed the pgxactoff field with its comment from PGPROC, but
haven't yet added a comment on PROC_HDR's pgxactoffs. Please add a
comment to the pgxactoffs array that describes its contents. A simple
adaptation of the comment removed with PGPROC's pgxactoff field should
be sufficient.
The comments on PROC_HDR and PGPROC also reference the deleted
PGPROC->pgxactoff field, so that also must be adjusted; there may be
several other places, as I didn't do a full check on the codebase.
Once the relevant comments are added and adjusted I think this is
ready for a committer.
Kind regards,
Matthias van de Meent
Databricks (https://www.databricks.com)
