Request a Demo
Home   >   mailing lists

Re: Pgbench: remove synchronous prepare - Mailing list pgsql-hackers

From lakshmi
Subject Re: Pgbench: remove synchronous prepare
Date
Msg-id CAEvyyTgeUC_FWrfy5Vpz9RrZ2L74Yv1B+yK8xs-8+VjgTJtz9g@mail.gmail.com
Whole thread
In response to Re: Pgbench: remove synchronous prepare  (Dmitrii Bondar <d.bondar@postgrespro.ru>)
List pgsql-hackers
Tree view

Hi Dmitrii,

Yes, my review is complete. The patch works well in my testing and resolves the blocking issue without any regressions.

You can move it to 'Ready for Committer.'

Regards,
Lakshmi G



On Thu, Apr 16, 2026 at 12:45 PM Dmitrii Bondar <d.bondar@postgrespro.ru> wrote:

Hi!

Thank you for reviewing my patch! Should I consider your review complete and move the patch to ‘ready for committer’?

On 4/6/26 1:54 PM, lakshmi wrote:


On Mon, Mar 23, 2026 at 11:45 AM Dmitrii Bondar <d.bondar@postgrespro.ru> wrote:
Rebase.

Hi Dmitrii,

I tested the latest patch with PgBouncer in session pooling mode (pool size 20, 21 clients).

Before applying the patch, pgbench got stuck under this setup and eventually hit a query_wait_timeout error.

After applying the patch, pgbench runs smoothly even when clients are queued. I can see continuous progress output and normal throughput (~60k TPS), with no errors or stalls.

The change works well in my testing.

Thanks for the patch!

Regards,
Lakshmi G

pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: Make copyObject work in C++
Next
From: Amul Sul
Date:
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid