Try
Home   >   mailing lists

Re: Trivial patch to fix a typo - Mailing list pgsql-hackers

From Chao Li
Subject Re: Trivial patch to fix a typo
Date
Msg-id CAEoWx2=2YZpYSGFxZNfaqPhiE2nX1h=Q_fnW54n_uY0dLRZ8ig@mail.gmail.com
Whole thread Raw
In response to Re: Trivial patch to fix a typo  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Trivial patch to fix a typo
List pgsql-hackers
Tree view
Ah ... Good to learn. Attached v2 updated the out file as well, now the test passed:

$ make check
...
# All 229 tests passed.

Thanks a lot.
Chao Li (Evan)
------------------------------
HighGo Software Inc.
https://www.highgo.com/


Michael Paquier <michael@paquier.xyz> 于2025年8月1日周五 15:04写道：
On Fri, Aug 01, 2025 at 02:56:33PM +0800, Chao Li wrote:
> I happened to catch this typo while reading the regression test code, so
> submitting a fix.
>
> As the typo is in the code comment, no test needs to run.

Incorrect.  The comment is included in the generated output, impacting
also foreign_key.out.  If you run a simple `make check` you would see
that the tests fail.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Trivial patch to fix a typo
Next
From: Peter Smith
Date:
Subject: Re: [WIP]Vertical Clustered Index (columnar store extension) - take2