Re: Missing const in DSA. - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Missing const in DSA.
Date
Msg-id CAEepm=3aCRzh35kYJf_2Eq39ALKhUXLzqHcrKFE=DwDQ3Y7FcA@mail.gmail.com
Whole thread Raw
In response to Re: Missing const in DSA.  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
On Tue, Sep 25, 2018 at 7:46 AM Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Tue, Sep 25, 2018 at 4:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > > On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >> Mark G <markg735@gmail.com> writes:
> > >>> While looking at some of the recent churn in DSA I noticed that
> > >>> dsa_size_class_map should probably be declared const.
> >
> > >> +1 ... also, given the contents of the array, "char" seems like
> > >> rather a misnomer.  I'd be happier if it were declared as uint8, say.

Pushed.  Thanks both for the code review!

-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Proposal for Signal Detection Refactoring
Next
From: Haribabu Kommi
Date:
Subject: Re: Revoke execution permission of pg_stat_statements_reset() frompg_read_all_stats role