Postgres Pro
Downloads
Home   >   mailing lists

Re: Missing const in DSA. - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Missing const in DSA.
Date
Msg-id CAEepm=1urhudvr-6RVb8KCa8-cUC0gRj6OP81q8tGOJ_J3ac0g@mail.gmail.com
Whole thread Raw
In response to Re: Missing const in DSA.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Missing const in DSA.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Mon, Sep 24, 2018 at 9:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Mark G <markg735@gmail.com> writes:
> > While looking at some of the recent churn in DSA I noticed that
> > dsa_size_class_map should probably be declared const.
>
> +1 ... also, given the contents of the array, "char" seems like
> rather a misnomer.  I'd be happier if it were declared as uint8, say.

+1

-- 
Thomas Munro
http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Next
From: Haribabu Kommi
Date:
Subject: Revoke execution permission of pg_stat_statements_reset() frompg_read_all_stats role