Postgres Pro
Downloads
Home   >   mailing lists

Re: DSM segment handle generation in background workers - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: DSM segment handle generation in background workers
Date
Msg-id CAEepm=1TmfPRPp3gnYdmEjAfvPK4Sn0QQu+TvihaOJTKEw7UDA@mail.gmail.com
Whole thread Raw
In response to Re: DSM segment handle generation in background workers  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Thu, Nov 15, 2018 at 4:25 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > What do you think about the attached?
>
> I think you need to cast MyStartTimestamp to uint64 before shifting
> to ensure portable behavior of the shifts.  In principle it wouldn't
> matter because the int64 sign bit is nowhere near the part we care
> about, but I've heard some pretty wild claims about what compiler
> writers are entitled to do with "undefined" cases.

Thanks.  Pushed.

-- 
Thomas Munro
http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Kohei KaiGai
Date:
Subject: lbound1 default in buildint2vector/buildoidvector
Next
From: Richard Guo
Date:
Subject: Re: Pull up sublink of type 'NOT NOT (expr)'