Re: DSM segment handle generation in background workers - Mailing list pgsql-hackers

From Tom Lane
Subject Re: DSM segment handle generation in background workers
Date
Msg-id 7673.1542209103@sss.pgh.pa.us
Whole thread Raw
In response to Re: DSM segment handle generation in background workers  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: DSM segment handle generation in background workers  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> What do you think about the attached?

I think you need to cast MyStartTimestamp to uint64 before shifting
to ensure portable behavior of the shifts.  In principle it wouldn't
matter because the int64 sign bit is nowhere near the part we care
about, but I've heard some pretty wild claims about what compiler
writers are entitled to do with "undefined" cases.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Memory leak in pg_config
Next
From: Dmitry Dolgov
Date:
Subject: Re: Refactoring the checkpointer's fsync request queue