Request a Demo
Home   >   mailing lists

Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
Date
Msg-id CAEG8a3KWE9bdOaVVrD22HtF93QTG27vdqfJ=BxEMCFKb1R_eUQ@mail.gmail.com
Whole thread Raw
In response to Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
List pgsql-hackers
Tree view 
On Mon, Nov 24, 2025 at 6:52 AM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote:
> > Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> > struct comments fail to express this, it says:
> >
> > indexkeys[], indexcollations[] each have ncolumns entries.
> >
> > So we should polish this description. trivial patch attached.
>
> Thanks. I agree with the patch.  We should probably mention
> canreturn[] too. I can take care of this.

Agreed. Thanks for taking care of this.

>
> David



--
Regards
Junwang Zhao

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Row pattern recognition
Next
From: Junwang Zhao
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)