Request a Demo
Home   >   mailing lists

Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length - Mailing list pgsql-hackers

From David Rowley
Subject Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
Date
Msg-id CAApHDvr7HHo5kfcCNX9YFDD3ogugB8V6JjXUSas+RrNwwbZs7A@mail.gmail.com
Whole thread Raw
In response to Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
List pgsql-hackers
Tree view 
On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote:
> Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> struct comments fail to express this, it says:
>
> indexkeys[], indexcollations[] each have ncolumns entries.
>
> So we should polish this description. trivial patch attached.

Thanks. I agree with the patch.  We should probably mention
canreturn[] too. I can take care of this.

David

pgsql-hackers by date:

Previous
From: Greg Burd
Date:
Subject: Re: Trying out
Next
From: Thomas Munro
Date:
Subject: Re: PRI?64 vs Visual Studio (2022)