Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH v1] eliminate duplicate code in table.c - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: [PATCH v1] eliminate duplicate code in table.c
Date
Msg-id CAEG8a3J=o8d1mrv4UBjicYMNn9ve4Y3crRkC=XxQJHcvFUkcUA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v1] eliminate duplicate code in table.c  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [PATCH v1] eliminate duplicate code in table.c
List pgsql-hackers
Tree view 
Here is the patch v7. Thanks!

On Fri, Jul 22, 2022 at 1:15 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Jul 22, 2022 at 7:39 AM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
> >
> > +                                errmsg("cannot operate on relation \"%s\"",
> >
> > Other callers of errdetail_relkind_not_supported() describing
> > operations concretely.  In that sense we I think should say "cannot
> > open relation \"%s\"" here.
> >
>
> Sounds reasonable to me. This will give more precise information to the user.
>
> --
> With Regards,
> Amit Kapila.



-- 
Regards
Junwang Zhao
Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery().
Next
From: Etsuro Fujita
Date:
Subject: Re: Fast COPY FROM based on batch insert