Re: [PATCH v1] eliminate duplicate code in table.c - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: [PATCH v1] eliminate duplicate code in table.c
Date
Msg-id CAA4eK1LUbLu0pMewdnuknzrZ-kLqhsehfjH3LpPFeS05Ctmx4Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH v1] eliminate duplicate code in table.c  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: [PATCH v1] eliminate duplicate code in table.c
List pgsql-hackers
On Fri, Jul 22, 2022 at 7:39 AM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
> +                                errmsg("cannot operate on relation \"%s\"",
>
> Other callers of errdetail_relkind_not_supported() describing
> operations concretely.  In that sense we I think should say "cannot
> open relation \"%s\"" here.
>

Sounds reasonable to me. This will give more precise information to the user.

-- 
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Handle infinite recursion in logical replication setup
Next
From: Amit Kapila
Date:
Subject: Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.