Re: [dsm] comment typo - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: [dsm] comment typo
Date
Msg-id CAEG8a3+Oq-k2p0jLoiYwh=Km254RL8R-sZWKekahwssQrJB2rw@mail.gmail.com
Whole thread Raw
In response to Re: [dsm] comment typo  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [dsm] comment typo
List pgsql-hackers
On Mon, Aug 21, 2023 at 5:16 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 18 Aug 2023, at 11:10, Junwang Zhao <zhjwpku@gmail.com> wrote:
> >
> > In the following sentence, I believe either 'the' or 'a' should be kept, not
> > both. I here keep the 'the', but feel free to change.
>
> >  * handle: The handle of an existing object, or for DSM_OP_CREATE, the
> > - *    a new handle the caller wants created.
> > + *    new handle the caller wants created.
>
> Since the handle doesn't exist for DSM_OP_CREATE, both "a handle" and "the
> handle" seems a tad misleading, how about "the identifier for the new handle the
> caller wants created"?
>

Sounds great 👍

> --
> Daniel Gustafsson
>


--
Regards
Junwang Zhao



pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Amit Kapila
Date:
Subject: Re: Adding a LogicalRepWorker type field