Re: A WalSnd issue related to state WALSNDSTATE_STOPPING - Mailing list pgsql-hackers

From Paul Guo
Subject Re: A WalSnd issue related to state WALSNDSTATE_STOPPING
Date
Msg-id CAEET0ZFr00MLhC-auSfszZ+LrbV5H1N0VNqeCn8oJ7PQbW9joA@mail.gmail.com
Whole thread Raw
In response to Re: A WalSnd issue related to state WALSNDSTATE_STOPPING  (Michael Paquier <michael@paquier.xyz>)
Responses Re: A WalSnd issue related to state WALSNDSTATE_STOPPING
List pgsql-hackers
On Thu, Nov 22, 2018 at 06:31:04PM +0800, Paul Guo wrote:
> Yes, please see the attached patch.

Thanks, I have reviewed your patch, and could not resist to change
SyncRepReleaseWaiters() on top of the rest with a comment to not be
confused about the WAL sender states allowed to release waiters.

The previous experience is proving that it seems unwise to rely on the
order of the elements in WalSndState, so I have tweaked things so as the
state is listed for all the code paths involved.

Paul, what do you think?
--
Michael

Agree. Your code change is safer.
 

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Pluggable Storage - Andres's take
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Block level parallel vacuum