Re: A WalSnd issue related to state WALSNDSTATE_STOPPING - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: A WalSnd issue related to state WALSNDSTATE_STOPPING
Date
Msg-id 20181126130212.GB14598@paquier.xyz
Whole thread Raw
In response to Re: A WalSnd issue related to state WALSNDSTATE_STOPPING  (Paul Guo <pguo@pivotal.io>)
Responses Re: A WalSnd issue related to state WALSNDSTATE_STOPPING  (Paul Guo <pguo@pivotal.io>)
List pgsql-hackers
On Thu, Nov 22, 2018 at 06:31:04PM +0800, Paul Guo wrote:
> Yes, please see the attached patch.

Thanks, I have reviewed your patch, and could not resist to change
SyncRepReleaseWaiters() on top of the rest with a comment to not be
confused about the WAL sender states allowed to release waiters.

The previous experience is proving that it seems unwise to rely on the
order of the elements in WalSndState, so I have tweaked things so as the
state is listed for all the code paths involved.

Paul, what do you think?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: SQL/JSON: functions
Next
From: Surafel Temesgen
Date:
Subject: Re: COPY FROM WHEN condition