Re: Logical replication can lose an update after concurrent index invalidation - Mailing list pgsql-hackers

Hello!

> RelationFindReplTupleByIndex() is an extern function declared in a
> core executor header (executor.h). Adding a new parameter
> (isIdxSafeToSkipDuplicates) changes its calling convention.
> Similarly I'm not sure of adding isidentity to LogicalRepRelMapEntry
> in back branches as it will change its size and memory layout.

Yep, fair, thanks.

In v2 I put a new flag into padding and used the same pattern for the
function as in 9e47718250d.

abidiff now shows that:

'struct LogicalRepRelMapEntry' changed:
  type size hasn't changed
  1 data member insertion:
    'bool isidentity', at offset 89 (in bytes)

I think it is ok for such a type. I couldn't find any usage in extensions.

Should we update .abi-compliance-history in such a case?

Best regards,
Mikhail.