Re: Macro redefinition warning after aeb07c55fab5c17a600b77ffcdc3b71425d6a8e7 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Macro redefinition warning after aeb07c55fab5c17a600b77ffcdc3b71425d6a8e7
Date
Msg-id 3526243.1782927177@sss.pgh.pa.us
Whole thread
List pgsql-hackers
"Tristan Partin" <tristan@partin.io> writes:
> When compiling, I get the following warnings:
>     [338/2397] Compiling C object src/timezone/zic.p/zic.c.o
>     In file included from ../src/timezone/zic.c:22:
>     ../src/timezone/private.h:187:9: warning: ‘unreachable’ redefined
>       187 | #define unreachable() pg_unreachable()
>           |         ^~~~~~~~~~~

Thanks for the report.

> The upstream code for private.h's definition of unreachable() looks 
> quite a bit different than ours[0].

Yeah.  I intentionally used our version rather than hoping that
theirs would work in our environment.  I still think that's the
right way, so I'm inclined to fix this by throwing in an "#undef".

            regards, tom lane



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Macro redefinition warning after aeb07c55fab5c17a600b77ffcdc3b71425d6a8e7
Next
From: "Tristan Partin"
Date:
Subject: Add malloc attribute to memory allocation functions