Re: Tab completion for TABLESAMPLE - Mailing list pgsql-hackers

From Brendan Jurd
Subject Re: Tab completion for TABLESAMPLE
Date
Msg-id CADxJZo0CN_Yno8s9sc0CE6RZDYUabmK8gG=6tOP233vwDGwcxA@mail.gmail.com
Whole thread Raw
In response to Re: Tab completion for TABLESAMPLE  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: Tab completion for TABLESAMPLE  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Fri, 19 Jun 2015 at 21:05 Petr Jelinek <petr@2ndquadrant.com> wrote:
On 2015-06-19 09:08, Brendan Jurd wrote:
> I
> think it would be convenient and user-friendly to complete the opening
> bracket -- it would make it perfectly clear that an argument is required
> for the syntax to be valid.
>

Agreed, here is updated version which does that.

Thanks Petr, I have tested your v2 and it works well.  This is ready for committer.

Cheers,
BJ

pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: pretty bad n_distinct estimate, causing HashAgg OOM on TPC-H
Next
From: Tomas Vondra
Date:
Subject: Re: pretty bad n_distinct estimate, causing HashAgg OOM on TPC-H