Remi Colinet wrote: > Hello, > > This is version 2 of the patch to make the file and block sizes for WAL and > relations, run-time configurable at initdb.
I don't think this works, since we have a rule that pallocs are prohibited within critical section and I see that your patch changes some stack-allocated variables to palloc'ed. For example I think the heap_page_prune changes should break some test or other.
Thank you for the head up.
For heap_page_prune() function, the critical section starts after the palloc() call and ends before the pfree().
Unless critical sections can be nested, we are outside such section.
For the other palloc()/pfree() uses to replace the stack allocation, either we already have palloc()/pfree() call.