Postgres Pro
Downloads
Home   >   mailing lists

Re: [Patch v2] Make block and file size for WAL and relationsdefined at cluster creation - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [Patch v2] Make block and file size for WAL and relationsdefined at cluster creation
Date
Msg-id 20180103221100.riszh4c3m2omor5r@alvherre.pgsql
Whole thread Raw
In response to [Patch v2] Make block and file size for WAL and relations defined atcluster creation  (Remi Colinet <remi.colinet@gmail.com>)
Responses Re: [Patch v2] Make block and file size for WAL and relations definedat cluster creation
List pgsql-hackers
Tree view 
Remi Colinet wrote:
> Hello,
> 
> This is version 2 of the patch to make the file and block sizes for WAL and
> relations, run-time configurable at initdb.

I don't think this works, since we have a rule that pallocs are
prohibited within critical section and I see that your patch changes
some stack-allocated variables to palloc'ed.  For example I think the
heap_page_prune changes should break some test or other.

This patch is too massive to review.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Subject: Re: [PATCH] Comment typo in get_collation_name() comment
Next
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] Comment typo in get_collation_name() comment