Try
Home   >   mailing lists

Re: More protocol.h replacements this time into walsender.c - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: More protocol.h replacements this time into walsender.c
Date
Msg-id CADK3HHLs-8fTiYikJBU45bkMYABVifkYPQU9s3vwO4EUcuOo=w@mail.gmail.com
Whole thread Raw
In response to Re: More protocol.h replacements this time into walsender.c  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view


On Fri, 25 Jul 2025 at 10:38, Nathan Bossart <nathandbossart@gmail.com> wrote:
On Thu, Jul 24, 2025 at 05:39:14PM -0400, Dave Cramer wrote:
> On Thu, 24 Jul 2025 at 17:05, Jacob Champion <
> jacob.champion@enterprisedb.com> wrote:
>> Since these are part of the replication subprotocol (i.e. tunneled,
>> via CopyData) rather than the top-level wire protocol, do they deserve
>> their own prefix? PqReplMsg_* maybe?
>>
> I'm going to wait to see if there are any other opinions. Last time I did
> this there were quite a few opinions before finally settling on the naming

+1 to a new prefix.  I don't have any strong opinions on the exact choice,
though.  PqReplMsg, ReplMsg, PqMsg_Repl, etc. seem like some obvious
options.

I chose PqReplMsg patch attached

Dave
Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PG 18 beta1 release notes misses mention of pg_noreturn
Next
From: Masahiko Sawada
Date:
Subject: Re: Make COPY format extendable: Extract COPY TO format implementations