Re: [WIP] pg_ping utility - Mailing list pgsql-hackers

From Phil Sorber
Subject Re: [WIP] pg_ping utility
Date
Msg-id CADAkt-jAhFP1tyNjx+eiQSO5kBSKPOPfnmyF64ScLit2Crq+Fg@mail.gmail.com
Whole thread Raw
In response to Re: [WIP] pg_ping utility  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [WIP] pg_ping utility  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Hum, it is not really consistent to use a magic number here, particularly in
> the case where an additional state would be added in the enum PGPing. So why
> not simply return PQPING_NO_ATTEMPT when there are incorrect options or you
> show the help and exit? Looks like the best option here.

Good point. I will make that change as well.

> --
> Michael Paquier
> http://michael.otacoo.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: logical changeset generation v3
Next
From: Simon Riggs
Date:
Subject: Re: Do we need so many hint bits?