Re: [HACKERS] Subscription code improvements - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] Subscription code improvements
Date
Msg-id CAD21AoCvuE1z60WEGcrOWrJccuz577SJV2Ce=Kxto+no+DjTPg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Subscription code improvements  (Stephen Frost <sfrost@snowman.net>)
Responses Re: [HACKERS] Subscription code improvements  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Petr,

On Thu, Aug 3, 2017 at 5:24 AM, Stephen Frost <sfrost@snowman.net> wrote:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> > I wish you'd stop splitting error message strings across multiple lines.
>> > I've been trapped by a faulty grep not matching a split error message a
>> > number of times :-(  I know by now to remove words until I get a match,
>> > but it seems an unnecessary trap for the unwary.
>>
>> Yeah, that's my number one reason for not splitting error messages, too.
>> It's particularly nasty if similar strings appear in multiple places and
>> they're not all split alike, as you can get misled into thinking that a
>> reported error must have occurred in a place you found, rather than
>> someplace you didn't.
>
> +1.
>

Are you planning to work on remaining patches 0005 and 0006 that
improve the subscription codes in PG11 cycle? If not, I will take over
them and work on the next CF.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [HACKERS] free space % calculation in pgstathashindex
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] FYI: branch for v11 devel is planned for next week