Re: [HACKERS] Subscription code improvements - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [HACKERS] Subscription code improvements
Date
Msg-id 20170802202443.GS1769@tamriel.snowman.net
Whole thread Raw
In response to Re: [HACKERS] Subscription code improvements  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Subscription code improvements  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > I wish you'd stop splitting error message strings across multiple lines.
> > I've been trapped by a faulty grep not matching a split error message a
> > number of times :-(  I know by now to remove words until I get a match,
> > but it seems an unnecessary trap for the unwary.
>
> Yeah, that's my number one reason for not splitting error messages, too.
> It's particularly nasty if similar strings appear in multiple places and
> they're not all split alike, as you can get misled into thinking that a
> reported error must have occurred in a place you found, rather than
> someplace you didn't.

+1.

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Subscription code improvements
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] WIP: Failover Slots