Re: [HACKERS] Comment in snapbuild.c file - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] Comment in snapbuild.c file
Date
Msg-id CAD21AoCuDaJKRWOZDOuDm=RXYtiDgDMvyLoXhxxnAJu8bYkUQw@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Comment in snapbuild.c file  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Sun, Aug 13, 2017 at 12:28 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Alvaro Herrera wrote:
>> Masahiko Sawada wrote:
>> > Hi all,
>> >
>> > In snapbuild.c file, there is a comment as follows.
>> >
>> >    * NB: Because of that xmax can be lower than xmin, because we only
>> >    * increase xmax when a catalog modifying transaction commits. While odd
>> >    * looking, it's correct and actually more efficient this way since we hit
>> >    * fast paths in tqual.c.
>> >    */
>>
>> I think the whole para needs to be rethought.
>
> Pushed, thanks.
>

Sorry for the late response. I agreed with your proposal. Thank you
for committing!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: [HACKERS] Thoughts on unit testing?
Next
From: Michael Paquier
Date:
Subject: [HACKERS] Simplify ACL handling for large objects and removal of superuser() checks