Re: FW: [Todo item] Add entry creation timestamp column to pg_stat_replication - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: FW: [Todo item] Add entry creation timestamp column to pg_stat_replication
Date
Msg-id CAD21AoCg1UHpYEwp-poDxtpG0rfQpox-m6++tEEJ+0-=pXLhog@mail.gmail.com
Whole thread Raw
In response to FW: [Todo item] Add entry creation timestamp column topg_stat_replication  (MyungKyu LIM <myungkyu.lim@samsung.com>)
List pgsql-hackers
On Thu, Aug 2, 2018 at 6:34 PM MyungKyu LIM <myungkyu.lim@samsung.com> wrote:
>
> I changed field name from 'reply_time' to 'last_msg_send_time'.
> Because 'last_msg_send_time' is used in pg_stat_wal_receiver/pg_stat_subsctiption view.
> I think that field has the same meaning.

I got confused by the field name. If we have 'last_msg_send_time'
field in pg_stat_replciation which has information of wal senders
users would think it as a time when the wal sender sent a message last
time. However values of the fields actually shows a time when the wal
receiver sent a reply message last time. So perhaps
'last_reply_send_time' would be more clear.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] generated columns
Next
From: "myungkyu.lim"
Date:
Subject: RE: [Todo item] Add entry creation timestamp column topg_stat_replication