RE: [Todo item] Add entry creation timestamp column topg_stat_replication - Mailing list pgsql-hackers

From myungkyu.lim
Subject RE: [Todo item] Add entry creation timestamp column topg_stat_replication
Date
Msg-id 007701d47cb9$8f414380$adc3ca80$@samsung.com
Whole thread Raw
In response to [Todo item] Add entry creation timestamp column topg_stat_replication  (MyungKyu LIM <myungkyu.lim@samsung.com>)
Responses Re: [Todo item] Add entry creation timestamp column topg_stat_replication  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi.

>> I changed field name from 'reply_time' to 'last_msg_send_time'.
>> Because 'last_msg_send_time' is used in pg_stat_wal_receiver/pg_stat_subsctiption view.
>> I think that field has the same meaning.
>
>I got confused by the field name. If we have 'last_msg_send_time'
>field in pg_stat_replciation which has information of wal senders
>users would think it as a time when the wal sender sent a message last
>time. However values of the fields actually shows a time when the wal
>receiver sent a reply message last time. So perhaps
>'last_reply_send_time' would be more clear.

Good point. 'last_reply_send_time' is better.
How about just 'reply_time'?

Best regards,
Myungkyu, Lim



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: FW: [Todo item] Add entry creation timestamp column to pg_stat_replication
Next
From: Michael Paquier
Date:
Subject: Re: Libpq support to connect to standby server as priority