On Tue, Jun 24, 2025 at 2:14 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Tue, Jun 24, 2025 at 1:59 PM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Tue, Jun 24, 2025 at 10:24:03AM +0900, Masahiko Sawada wrote:
> > > I've added the patch for that idea for discussion. I considered moving
> > > the new cache-behavior-dependent test to another test file to minimize
> > > the maintenance effort but didn't do that at this stage as the test
> > > file has only a few tests.
> >
> > The spec test file only includes two short permutations, making the
> > generated output really short. A secondary output file sounds fine to
> > me as long as you document in the spec file the reason why the file is
> > around, and your patch does that.
> >
> > +# This file contains cache-behavior-dependent test case. Their reults are
> > [..]
> > +# two expected-output files to cvoer both cases.
> >
> > Two typos in three lines of comments: s/reults/results/ and
> > s/cvoer/cover/.
>
> Thank you for reviewing the patch!
>
> I've attached the updated patch. I'm going to push it barring further comments.
>
Forgot to record. I pushed the fix[1] and confirmed that trilobite is
back to green.
Regards,
[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=d87d07b7ad3b782cb74566cd771ecdb2823adf6a
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
