Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM
Date
Msg-id CAD21AoBWNmdL5CHWUHKDaMgD=F1Vj-w28ZBNhYRXQEhOMxsLaA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Report the number of skipped frozen pages by manualVACUUM  (Jim Nasby <jim.nasby@openscg.com>)
Responses Re: [HACKERS] Report the number of skipped frozen pages by manualVACUUM  (Jim Nasby <jim.nasby@openscg.com>)
Re: [HACKERS] Report the number of skipped frozen pages by manualVACUUM  (Yugo Nagata <nagata@sraoss.co.jp>)
List pgsql-hackers
On Fri, Mar 10, 2017 at 3:58 PM, Jim Nasby <jim.nasby@openscg.com> wrote:
> On 3/6/17 8:34 PM, Masahiko Sawada wrote:
>>
>> I don't think it can say "1 frozen pages" because the number of
>> skipped pages according to visibility map is always more than 32
>> (SKIP_PAGES_THRESHOLD).
>
>
> That's just an artifact of how the VM currently works. I'm not a fan of
> cross dependencies like that unless there's a pretty good reason.

Thank you for the comment.
Agreed. Attached fixed version patch.

> BTW, I think there's already a function that handles the pluralization for
> you. IIRC it's one of the things you can add to an ereport() call.

What is the function name?

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: "Tels"
Date:
Subject: Re: [HACKERS] Parallel Append implementation
Next
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers