Re: Assert("vacrel->eager_scan_remaining_successes > 0") - Mailing list pgsql-hackers

On Thu, May 22, 2025 at 1:19 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> On Thu, May 22, 2025 at 4:07 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Agreed. I've updated the patch. Does this address your comments?
>
> Yep. LGTM.
>
> I'd probably just remove the parenthetical remark about 20% from the
> commit message since that only applies to the success cap and
> referencing both the success and failure caps will make the sentence
> very long.
>
> from the commit message:
>      pages (beyond 20% of the total number of all-visible but not
>      all-frozen pages), this does not pose a practical concern as the

Agreed.

I'll remove that part and push early next week, barring any objections.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com