Re: Assert("vacrel->eager_scan_remaining_successes > 0") - Mailing list pgsql-hackers

From Melanie Plageman
Subject Re: Assert("vacrel->eager_scan_remaining_successes > 0")
Date
Msg-id CAAKRu_aBkNpb_4n6Rm=J5igVRTmzO09EFpUaaq3LogHSbkckNA@mail.gmail.com
Whole thread Raw
In response to Re: Assert("vacrel->eager_scan_remaining_successes > 0")  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Thu, May 22, 2025 at 4:07 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Agreed. I've updated the patch. Does this address your comments?

Yep. LGTM.

I'd probably just remove the parenthetical remark about 20% from the
commit message since that only applies to the success cap and
referencing both the success and failure caps will make the sentence
very long.

from the commit message:
     pages (beyond 20% of the total number of all-visible but not
     all-frozen pages), this does not pose a practical concern as the

Thanks again for writing the patch!

- Melanie



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Log connection establishment timings
Next
From: Greg Sabino Mullane
Date:
Subject: Re: [Util] Warn and Remove Invalid GUCs