Re: transformJsonFuncExpr pathspec cache lookup failed - Mailing list pgsql-hackers

On Fri, Nov 7, 2025 at 2:26 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> Hi!
> I tried your fix and this indeed fixes an issue. Two minor comments:
>
> First,
> in the `src/backend/parser/parse_expr.c` fil there are multiple
> examples of working with `coerce_to_target_type`, they all share
> different coding practice:
>
> ```
> coerced_expr = coerce_to_target_type(.., expr, ..)
>
> if (coerced_expr == NULL)
>      ereport();
>
>
> expr = coerced_expr;
> ```
>
> Instead of
> ```
> expr = coerce_to_target_type(.., expr, ..)
>
> if (expr == NULL)
>      ereport();
> ```
>
> Let's be consistent?
>

IMHO,
> coerced_expr = coerce_to_target_type(.., expr, ..)
is better than
> expr = coerce_to_target_type(.., expr, ..)

I changed accordingly.