Postgres Pro
Downloads
Home   >   mailing lists

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN - Mailing list pgsql-hackers

From Maxim Orlov
Subject Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
Date
Msg-id CACG=ezZkhtCzeCkDY=WVYwvsNt0XffRZ7a7x6yH=D14cW=Eo8w@mail.gmail.com
Whole thread Raw
In response to Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
List pgsql-hackers
Tree view
Hi!

+1 for the idea of the patch. Consider it useful.

I looked at the patch set and don't see any obvious defects. It applies without any problems and looks pretty good for me.
Only one thing is left to do. Add basic tests for the added functionality to make it committable.  For example, as in the 
mentioned 1eff8279d494b9.

--
Best regards,
Maxim Orlov.

pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: Re: Set log_lock_waits=on by default
Next
From: Andres Freund
Date:
Subject: Re: AIO v2.0