Postgres Pro
Downloads
Home   >   mailing lists

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
Date
Msg-id 20240904.090657.995734319001610943.ishii@postgresql.org
Whole thread Raw
In response to Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN  (Maxim Orlov <orlovmg@gmail.com>)
Responses Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
List pgsql-hackers
Tree view 
> Hi!
> 
> +1 for the idea of the patch. Consider it useful.
> 
> I looked at the patch set and don't see any obvious defects. It applies
> without any problems and looks pretty good for me.

Thank you for reviewing my patch.

> Only one thing is left to do. Add basic tests for the added functionality
> to make it committable.  For example, as in the
> mentioned 1eff8279d494b9.

Agreed. Probably add to explain.sql?

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

pgsql-hackers by date:

Previous
From: Ilya Gladyshev
Date:
Subject: Re: optimizing pg_upgrade's once-in-each-database steps
Next
From: Richard Guo
Date:
Subject: Re: Wrong results with grouping sets