Hi Murtuza,
Please find below review comments.
- Remove the whitespace from the patch file as we are getting below warnings while applying the patch file.
schema_catalog_node_v1.patch:1500: trailing whitespace.
FROM pg_namespace nsp
schema_catalog_node_v1.patch:1501: trailing whitespace.
LEFT OUTER JOIN
schema_catalog_node_v1.patch:1672: trailing whitespace.
FROM pg_namespace nsp
schema_catalog_node_v1.patch:1673: trailing whitespace.
LEFT OUTER JOIN
schema_catalog_node_v1.patch:2353: trailing whitespace.
(SELECT defaclobjtype, aclexplode(defaclacl) as acl
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
- Some of the Properties are not getting displayed under Properties panel of schema. Make sure to display all the properties displayed in pgadmin3.
e.g. System Schema
- We are getting error at python side saying "ValueError: View function did not return a response" while editing the schema node.
- Default Privileges are not getting displayed under SQL panel.
- When we connect to PostgreSQL 9.1 database then we are getting error fail to execute query as below. Below error will be for both schema and
catalog node.
ERROR pgadmin: Failed to execute query (execute_2darray) for the server #3 - DB:postgres (Query-id: 1019298):
Error Message:relation "pg_shseclabel" does not exist
LINE 11: ... (SELECT array_agg(provider || '=' || label) FROM pg_shsecla...
Thanks,
Neel Patel
