Re: [DOCS] Behavior of recovery_target_inclusive. - Mailing list pgsql-docs

From Tomonari Katsumata
Subject Re: [DOCS] Behavior of recovery_target_inclusive.
Date
Msg-id CAC55fYdSS80-bTqc7Z=MGvH=44e9ORAeQyXO7rarGhhr0_mCVA@mail.gmail.com
Whole thread Raw
In response to Re: [DOCS] Behavior of recovery_target_inclusive.  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [DOCS] Behavior of recovery_target_inclusive.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-docs
Hi Michael

Thanks for your reply and quick reaction.

2017-10-23 23:05 GMT+09:00 Michael Paquier <michael.paquier@gmail.com>:
On Mon, Oct 23, 2017 at 10:27 PM,  <t.katsumata1122@gmail.com> wrote:
> At &quot;recovery_target_inclusive (boolean)&quot;, nothing is mentioned about
> &quot;recovery_target_lsn&quot;.
> It should be fixed, since &quot;recovery_target_lsn&quot; is affected by the value of
> &quot;recovery_target_inclusive&quot;.
>
> Could you check this?

Apologies. You are right, this is a documentation bug and should be
fixed. Attached is a patch to address the problem. The trend on the
documentation page for recovery parameters is to list the options
alphabetically, so recovery_target_lsn comes first.
--
Michael

Your patch seems good, but I have a question.
Does it need to fix the next sentence?
Like this:
----
This setting controls whether transactions having exactly the target WAL location (LSN), commit time or ID, respectively, will be included in the recovery.
----


Best regards,

pgsql-docs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [DOCS] Behavior of recovery_target_inclusive.
Next
From: Michael Paquier
Date:
Subject: Re: [DOCS] Behavior of recovery_target_inclusive.