Re: WIN32 pg_import_system_collations - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: WIN32 pg_import_system_collations
Date
Msg-id CAC+AXB3Wx3CH-1OBEg_1uWcAOzYQ-S+B3_c0emhmgejgen7iNw@mail.gmail.com
Whole thread Raw
In response to Re: WIN32 pg_import_system_collations  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Responses Re: WIN32 pg_import_system_collations
List pgsql-hackers

On Wed, Nov 9, 2022 at 12:02 AM Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> wrote:
On Mon, Nov 7, 2022 at 4:08 PM Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:

This looks pretty good to me.  The refactoring of the non-Windows parts
makes sense.  The Windows parts look reasonable on manual inspection,
but again, I don't have access to Windows here, so someone else should
also look it over.

I was going to say that at least it is getting tested on the CI, but I have found out that meson changes version(). That is fixed in this version.

Now is currently failing due to [1], so maybe we can leave this patch on hold until that's addressed. 


Regards,

Juan José Santamaría Flecha


pgsql-hackers by date:

Previous
From: Juan José Santamaría Flecha
Date:
Subject: Meson doesn't define HAVE_LOCALE_T for mscv
Next
From: Richard Guo
Date:
Subject: Re: Making Vars outer-join aware