> > what we should do is clean them up (and possibly > > throw a WARNING or similar at the user saying "something modified your > > postgresql.auto.conf in an unexpected way"). I'd suggest we do that on > > every ALTER SYSTEM call. > > +1 for having ALTER SYSTEM clean out duplicates. Not sure whether > a WARNING would seem too in-your-face.
I'd hope for a warning from basically every part of the system when it detects, clearly, that a file was changed in a way that it shouldn't have been. If we don't throw a warning, then we're implying that it's acceptable, but then cleaning up the duplicates, which seems pretty confusing.
+1. Silently "fixing" the file by cleaning up duplicates is going to be even more confusing to uses who had seen them be there before.
