Re: Add session statistics to pg_stat_database - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Add session statistics to pg_stat_database
Date
Msg-id CABUevEyoOxgK3BKYNgwxJa_EXmtu_NV4d+v0F-v_B1MGA8FosQ@mail.gmail.com
Whole thread Raw
In response to Re: Add session statistics to pg_stat_database  (Laurenz Albe <laurenz.albe@cybertec.at>)
List pgsql-hackers
On Mon, Jan 18, 2021 at 5:11 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
>
> On Sun, 2021-01-17 at 14:07 +0100, Magnus Hagander wrote:
> > I have applied this version, with some minor changes:
> >
> > * I renamed the n_<x>_time members in the struct to just
> > total_<x>_time. The n_ indicates "number of" and is thus wrong for
> > time parameters.
>
> Right.
>
> > * Some very minor wording changes.
> >
> > * catversion bump (for once I didn't forget it!)
>
> Thank you!
>
> You included the catversion bump, but shouldn't PGSTAT_FILE_FORMAT_ID
> in "include/pgstat.h" be updated as well?

Yup, you are absolutely correct. Will fix.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: support for MERGE
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] ProcessInterrupts_hook