Re: Unexpected Standby Shutdown on sync_replication_slots change - Mailing list pgsql-bugs

From Xuneng Zhou
Subject Re: Unexpected Standby Shutdown on sync_replication_slots change
Date
Msg-id CABPTF7XDvcPK76zYSa+onN0G0GSi9=rsF6emrb8-3v=ArCCEew@mail.gmail.com
Whole thread Raw
In response to Re: Unexpected Standby Shutdown on sync_replication_slots change  (shveta malik <shveta.malik@gmail.com>)
List pgsql-bugs
Hi,

On Wed, Jul 30, 2025 at 11:15 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Tue, Jul 29, 2025 at 12:04 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> >
> > On Tue, 2025-07-29 at 13:40 +0900, Fujii Masao wrote:
> > > I think it's basically not acceptable for a server to start up
> > > successfully before a minor version update, but then fail to start with
> > > the same configuration after the update. If that's absolutely necessary
> > > to fix a bug, it might be justifiable. But in this case, I don't think
> > > it's required.
> > >
> > > Blocking startup when sync_replication_slots is enabled and wal_level
> > > is not logical could be helpful. But that feels more like an improvement
> > > than a bug fix. I'm fine adding that to master, but I don't think we should
> > > apply it to old branches.
> > >
> > > That said, both Shveta and Amit support backpatching this change,
> > > so I'd like to hear more opinions before we decide.
> >
> > I side with you on that one.
> >
> > I think it would be fine to backpatch the breaking change to v18,
> > if we mention the behavior change in the release notes.
> >
>
> I am fine with the suggestion.

+ 1

This fix does feel more like an enhancement to user feedback and
safety nets, not a correction of a broken or unsafe code path. Unable
to start up with the same settings for it might cause
more-than-necessary surprise.

Best,
Xuneng



pgsql-bugs by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Use-after-free in reorderbuffer.c for INSERT ON CONFLICT
Next
From: Michael Paquier
Date:
Subject: Re: Use-after-free in reorderbuffer.c for INSERT ON CONFLICT