Re: Update EnableTimeoutParams timeout type comment - Mailing list pgsql-hackers

Hi John,

On Wed, Jul 1, 2026 at 12:01 PM John Naylor <johncnaylorls@gmail.com> wrote:
>
> On Wed, Jul 1, 2026 at 8:44 AM Xuneng Zhou <xunengzhou@gmail.com> wrote:
> > While reading the timeout code, I noticed that the comment for
> > EnableTimeoutParams timeout type is kinda stale. Currently, we support
> > three types of timeout TMPARAM_AFTER/AT/EVERY, but the comment only
> > mentions the first two. It may not cause confusion, since the two
> > structs are adjacent, but it might still be worth making this clearer.
> > Attached a patch to update it.
>
> It seems pointless to have a comment whose entire content is to list
> every current enum member of that type. I'd just delete the comment,
> since it's likely to just going to get outdated again. If any other
> objects of type enum have this, they should get the same treatment.

Agreed. The comment just duplicates nearby code and can easily go
stale again. Removing it also makes sense to me. Here's the patch with
the treatment.

--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.