Re: Add pg_stat_kind_info system view - Mailing list pgsql-hackers

From Sami Imseih
Subject Re: Add pg_stat_kind_info system view
Date
Msg-id CAA5RZ0uHwtnkVEF=R6s2f8En8UooyEn-48+byVjEKbzQ0_ZMmw@mail.gmail.com
Whole thread
In response to Re: Add pg_stat_kind_info system view  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Add pg_stat_kind_info system view
List pgsql-hackers
> > > I think this should be 0 for all kinds by default. Only ever > 0 for
> > > variable-numbered
> > > kinds with entry tracking enabled. No NULLs. The fields should be called
> > > "entry_count" instead of "count". We should update the documentation to
> > > reflect that as well. That seems easier to query than having mixed NULLs and
> > > numbers.
> >
> > IMO, in this case, NULL should be a synonym of "I don't know", which
> > is what entry_count set to false means.  0 means "I know, there is no
> > data".  I'd be OK with dropping the part about fixed-sized stats where
> > we enforce 1, and use NULL instead, though.
>
> +1, that's also my opinion [1].
>
> [1]: https://postgr.es/m/ajtroNXfBS/ldtNZ%40bdtpg

I'm ok with that if others feel this is better.

--
Sami



pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: Update EnableTimeoutParams timeout type comment
Next
From: Xuneng Zhou
Date:
Subject: Re: Update EnableTimeoutParams timeout type comment