Re: pg_upgrade in 9.5 broken for adminpack - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_upgrade in 9.5 broken for adminpack
Date
Msg-id CAB7nPqTN6aOFmNT4+VZKWOE7JYaG5PZVx+Kb3N6DLe=mNd1mdA@mail.gmail.com
Whole thread Raw
In response to Re: pg_upgrade in 9.5 broken for adminpack  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: pg_upgrade in 9.5 broken for adminpack
List pgsql-hackers
On Fri, Apr 17, 2015 at 3:29 PM, Jeff Janes wrote:
> Of course after sending that it became obvious.  The C function is not
> getting called because the SQL function is marked as being strict, yet is
> called with NULL arguments.
>
> Trivial patch attached to unset strict flag in pg_proc.h.
>
> But  CATALOG_VERSION_NO probably needs another bump as well.

This looks good to me. I have tested your fix and the problem goes
away. create_empty_extension() was the only function not declared as
STRICT before 30982be4 (see install_support_functions_in_new_db() in
contrib/pg_upgrade/function.c).
Regards,
-- 
Michael



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: pg_upgrade in 9.5 broken for adminpack
Next
From: Michael Paquier
Date:
Subject: Re: Moving on to close the current CF 2015-02