Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Error while copying a large file in pg_rewind - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Error while copying a large file in pg_rewind
Date
Msg-id CAB7nPqT9ifOW1Vq4_9uECX8qBY=QfuZd_G9Kqxjz=bC85VSeew@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Error while copying a large file in pg_rewind  (Kuntal Ghosh <kuntalghosh.2007@gmail.com>)
Responses Re: [HACKERS] Error while copying a large file in pg_rewind
List pgsql-hackers
Tree view 
On Fri, Jul 7, 2017 at 4:31 PM, Kuntal Ghosh <kuntalghosh.2007@gmail.com> wrote:
> On Fri, Jul 7, 2017 at 7:49 AM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
> I don't have any more inputs on this patch and it looks good to me.
> So, I'm moving the status to ready for committer.

Thanks!

>> At some point it would really make sense to group all things under the
>> same banner (64-b LO, pg_basebackup, and now pg_rewind).
>>
> +1. Implementation-wise, I prefer pg_recvint64 to fe_recvint64.

So do I. That's a matter of taste I guess.
-- 
Michael

pgsql-hackers by date:

Previous
From: Kuntal Ghosh
Date:
Subject: Re: [HACKERS] Error while copying a large file in pg_rewind
Next
From: Mark Kirkwood
Date:
Subject: Re: [HACKERS] New partitioning - some feedback