Re: The real reason why TAP testing isn't ready for prime time - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: The real reason why TAP testing isn't ready for prime time
Date
Msg-id CAB7nPqT4ZPSzh0y30Ha0HK32_8mKeoQvEvHTqxP5Maoi-MFRjg@mail.gmail.com
Whole thread Raw
In response to Re: The real reason why TAP testing isn't ready for prime time  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: The real reason why TAP testing isn't ready for prime time  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Fri, Jun 19, 2015 at 11:45 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> Attached is a patch fixing those problems and improving the log
>> facility as it really helped me out with those issues. The simplest
>> fix would be to include the -w switch missing in the tests of
>> pg_rewind and pg_ctl though.
>
> I agree with adding the -w switch and will go do that.  As far as the
> rest of this patch goes, it seems like it could be made less invasive
> if the logs got dumped into a subdirectory of tmp_check rather than
> adding another top-level directory that has to be cleaned?

tmp_check remains unused since dcae5fac (missing something perhaps?),
but I guess we could use it again to save the logs in it, and have
pg_rewind do the same.
-- 
Michael



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Need Multixact Freezing Docs
Next
From: Vik Fearing
Date:
Subject: Insufficient locking for ALTER DEFAULT PRIVILEGES