Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Date
Msg-id CAB7nPqT+tAPcH9BuZrp95ggDRJPhseVEW_HH8eeFpev8H6tUQA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On Tue, Mar 22, 2016 at 10:20 AM, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 03/21/2016 09:25 AM, Tom Lane wrote:
>>
>> Andres Freund <andres@anarazel.de> writes:
>>>
>>> On 2016-03-21 22:38:50 +1300, David Rowley wrote:
>>>>
>>>> Perl is not my native tongue, but after a little study and some
>>>> testing on a windows machine, the attached seems to fix the problem.
>>>
>>> I've pushed this, as I would like the buildfarm to be green before
>>> pushing the latch rework...
>>
>> Thanks!  If Andrew or somebody has a nicer solution, they can improve
>> this later.
>
> I've reviewed the changes briefly. They seem sane enough, although the code
> could do with a little logical reordering.

We're stuck with the list of files defined in OBJS, and psql's
Makefile is listing psqlscan.o, so that's still the best way to go.
--
Michael


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Next
From: Fujii Masao
Date:
Subject: pgsql: Fix typo in docs.