Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.
Date
Msg-id 56F09DE5.9020405@dunslane.net
Whole thread Raw
In response to Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-committers

On 03/21/2016 09:25 AM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2016-03-21 22:38:50 +1300, David Rowley wrote:
>>> Perl is not my native tongue, but after a little study and some
>>> testing on a windows machine, the attached seems to fix the problem.
>> I've pushed this, as I would like the buildfarm to be green before
>> pushing the latch rework...
> Thanks!  If Andrew or somebody has a nicer solution, they can improve
> this later.
>


I've reviewed the changes briefly. They seem sane enough, although the
code could do with a little logical reordering.

cheers

andrew



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve header output from psql's \watch command.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9.